enable Reproducible Builds #6801

hboutemy · 2022-10-03T17:13:20Z

Description

This PR enable Reproducible Builds: https://maven.apache.org/guides/mini/guide-reproducible-builds.html

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

boring-cyborg · 2022-10-03T17:13:23Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

sonarqubecloud · 2022-10-03T18:06:29Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov · 2022-10-03T20:45:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.46%. Comparing base (f417c6b) to head (aa9c6e4).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6801      +/-   ##
============================================
- Coverage     17.46%   17.46%   -0.01%     
+ Complexity    15516    15513       -3     
============================================
  Files          5913     5913              
  Lines        529385   529385              
  Branches      64679    64679              
============================================
- Hits          92448    92440       -8     
- Misses       426518   426527       +9     
+ Partials      10419    10418       -1

Flag	Coverage Δ
uitests	`3.58% <ø> (ø)`
unittests	`18.52% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hboutemy · 2022-10-06T13:20:32Z

@DaanHoogland

DaanHoogland · 2022-10-06T14:54:30Z

@blueorangutan package

blueorangutan · 2022-10-06T14:55:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-06T15:46:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4365

DaanHoogland · 2022-10-06T20:02:32Z

@blueorangutan test

blueorangutan · 2022-10-06T20:03:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

client/pom.xml

hboutemy · 2022-10-06T20:06:59Z

pom.xml

                <plugin>
                    <groupId>org.apache.maven.plugins</groupId>
                    <artifactId>maven-release-plugin</artifactId>
-                    <version>${cs.release-plugin.version}</version>


also inherited from parent

I'm not sure if root pom.xml has a parent cc @DaanHoogland

blueorangutan · 2022-10-06T20:14:30Z

Trillian Build Failed (tid-5077)

rohityadavcloud · 2022-10-08T06:27:45Z

@blueorangutan package

blueorangutan · 2022-10-08T06:28:03Z

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-08T08:50:34Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4381

DaanHoogland · 2022-10-10T19:20:00Z

@blueorangutan package

blueorangutan · 2022-10-10T19:21:02Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-10T20:17:32Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4413

DaanHoogland · 2022-10-11T15:24:35Z

@blueorangutan test

blueorangutan · 2022-10-11T15:25:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-10-12T04:22:37Z

Trillian test result (tid-5099)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45217 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6801-t5099-kvm-centos7.zip
Smoke tests completed. 101 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_15_retrieve_ssvm_default_files	`Error`	1.09	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Error`	1.09	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Error`	1.08	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	1.09	test_diagnostics.py
test_create_pvlan_network	`Error`	0.05	test_pvlan.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	3620.71	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	73.93	test_kubernetes_clusters.py

DaanHoogland · 2022-10-12T18:48:44Z

@blueorangutan package

blueorangutan · 2022-10-12T18:49:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-12T20:22:15Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4437

DaanHoogland · 2022-10-13T06:55:04Z

@blueorangutan test

Signed-off-by: Daan Hoogland <daan@onecht.net>

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>

DaanHoogland · 2024-10-11T09:42:50Z

@rohityadavcloud as we are going to get pressure to produce reproducible builds, should we move the diagnostics tests (that use zips) to component tests? cc @GutoVeronezi @sureshanaparti @weizhouapache ...

weizhouapache · 2024-10-11T13:05:25Z

@blueorangutan package

blueorangutan · 2024-10-11T13:06:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-11T14:15:50Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11320

weizhouapache · 2024-10-11T15:56:56Z

@blueorangutan test

blueorangutan · 2024-10-11T15:58:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-12T07:56:03Z

[SF] Trillian test result (tid-11654)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6801-t11654-kvm-ol8.zip
Smoke tests completed. 128 look OK, 2 have errors, 11 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_15_retrieve_ssvm_default_files	`Error`	1.11	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Error`	1.10	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Error`	1.09	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	1.10	test_diagnostics.py
test_01_secure_vm_migration	`Error`	134.06	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.06	test_vm_life_cycle.py
all_test_vm_strict_host_tags	`Skipped`	---	test_vm_strict_host_tags.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

github-actions · 2024-12-03T08:52:38Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

enable Reproducible Builds

a198440

boring-cyborg bot added the component:build label Oct 3, 2022

DaanHoogland self-assigned this Oct 6, 2022

hboutemy commented Oct 6, 2022

View reviewed changes

client/pom.xml Show resolved Hide resolved

hboutemy commented Oct 6, 2022

View reviewed changes

sureshanaparti added the status:needs-testing label Oct 13, 2022

DaanHoogland approved these changes Oct 13, 2022

View reviewed changes

DaanHoogland and others added 11 commits October 4, 2024 11:00

fix quota resource access validation

123b426

Validate QCOW2 on upload and register

4fa22f4

util: check JSESSIONID in cookies if user is passed

13dd698

Fix Vue devServer after CSRF fix

b3f9824

Updating pom.xml version numbers for release 4.19.1.2

18fe422

Signed-off-by: Daan Hoogland <daan@onecht.net>

Fix updateTemplatePermission when the UI is set to a language other…

d6181d5

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>

Filter list VMs by IP address (apache#9547)

9c86c4d

Fix Listing backup schedules (apache#9749)

8925ac7

Merge tag '4.19.1.2' into 4.19

05a44d8

Merge branch '4.18' into 4.19

8d819ec

Merge branch '4.19'

e5bd83e

Merge branch 'main' into main

ab05d34

DaanHoogland force-pushed the main branch from e5bd83e to 046870e Compare October 11, 2024 15:08

github-actions bot added the status:has-conflicts label Dec 3, 2024

Merge branch 'main' into main

eface4c

github-actions bot removed the status:has-conflicts label Dec 3, 2024

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti modified the milestones: 4.21.0, unplanned Jun 5, 2025

Merge branch 'main' into main

aa9c6e4

enable Reproducible Builds #6801

Are you sure you want to change the base?

enable Reproducible Builds #6801

Conversation

hboutemy commented Oct 3, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

boring-cyborg bot commented Oct 3, 2022

Uh oh!

sonarqubecloud bot commented Oct 3, 2022

Uh oh!

codecov bot commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hboutemy commented Oct 6, 2022

Uh oh!

DaanHoogland commented Oct 6, 2022

Uh oh!

blueorangutan commented Oct 6, 2022

Uh oh!

blueorangutan commented Oct 6, 2022

Uh oh!

DaanHoogland commented Oct 6, 2022

Uh oh!

blueorangutan commented Oct 6, 2022

Uh oh!

Uh oh!

hboutemy Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

rohityadavcloud Dec 12, 2022

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 6, 2022

Uh oh!

rohityadavcloud commented Oct 8, 2022

Uh oh!

blueorangutan commented Oct 8, 2022

Uh oh!

blueorangutan commented Oct 8, 2022

Uh oh!

DaanHoogland commented Oct 10, 2022

Uh oh!

blueorangutan commented Oct 10, 2022

Uh oh!

blueorangutan commented Oct 10, 2022

Uh oh!

DaanHoogland commented Oct 11, 2022

Uh oh!

blueorangutan commented Oct 11, 2022

Uh oh!

blueorangutan commented Oct 12, 2022

Uh oh!

DaanHoogland commented Oct 12, 2022

Uh oh!

blueorangutan commented Oct 12, 2022

Uh oh!

blueorangutan commented Oct 12, 2022

Uh oh!

DaanHoogland commented Oct 13, 2022

Uh oh!

DaanHoogland commented Oct 11, 2024

Uh oh!

weizhouapache commented Oct 11, 2024

Uh oh!

blueorangutan commented Oct 11, 2024

Uh oh!

blueorangutan commented Oct 11, 2024

Uh oh!

weizhouapache commented Oct 11, 2024

Uh oh!

blueorangutan commented Oct 11, 2024

Uh oh!

codecov bot commented Oct 3, 2022 •

edited

Loading