Skip to content

Fix timezone parsing regression in FastDateParser #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujwal2203 wants to merge 5 commits into
base: master
Choose a base branch
from
+22 −2
Open

Fix timezone parsing regression in FastDateParser #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1aad2b3
Fix regex for ISO_8601_3_STRATEGY time zone parsing
ujwal2203 Dec 23, 2025
8132eb9
Merge branch 'apache:master' into master
ujwal2203 Dec 23, 2025
92cdaed
Refactor ISO8601_3_STRATEGY regex for clarity
ujwal2203 Jan 5, 2026
4c44de3
Add test coverage for ISO-8601 timezone parsing variants
ujwal2203 Jan 5, 2026
e57e6bf
Refactor ISO8601 timezone test for clarity
ujwal2203 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/apache/commons/lang3/time/FastDateParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ private static final class ISO8601TimeZoneStrategy extends PatternStrategy {
// Z, +hh, -hh, +hhmm, -hhmm, +hh:mm or -hh:mm

private static final Strategy ISO_8601_1_STRATEGY = new ISO8601TimeZoneStrategy("(Z|(?:[+-]\\d{2}))");

private static final Strategy ISO_8601_2_STRATEGY = new ISO8601TimeZoneStrategy("(Z|(?:[+-]\\d{2}\\d{2}))");

private static final Strategy ISO_8601_3_STRATEGY = new ISO8601TimeZoneStrategy("(Z|(?:[+-]\\d{2}(?::)\\d{2}))");
/**
* Factory method for ISO8601TimeZoneStrategies.
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/org/apache/commons/lang3/time/FastDateParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,5 +747,27 @@ private void validateSdfFormatFdpParseEquality(final String formatStr, final Loc
}
}
}

// Test case for # PR1543
@Test
public void testISO8601TimezoneVariants() throws Exception {
final FastDateParser parserWithColon =
new FastDateParser(
"yyyy-MM-dd'T'HH:mm:ssXXX",
TimeZone.getTimeZone("UTC"),
Locale.US
);

final FastDateParser parserWithoutColon =
new FastDateParser(
"yyyy-MM-dd'T'HH:mm:ssXX",
TimeZone.getTimeZone("UTC"),
Locale.US
);


parserWithColon.parse("2025-01-01T10:00:00+05:30");
parserWithoutColon.parse("2025-01-01T10:00:00+0530");
}
}