Skip to content

LANG-1806: Allow floating-point suffixes in NumberUtils.isParsable #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jagdish-Singh-Bisht wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

LANG-1806: Allow floating-point suffixes in NumberUtils.isParsable #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/apache/commons/lang3/math/NumberUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,8 +753,15 @@ private static boolean isParsableDecimal(final String str, final int beginIdx) {
// See https://docs.oracle.com/javase/specs/jls/se8/html/jls-3.html#jls-NonZeroDigit
int decimalPoints = 0;
boolean asciiNumeric = true;
final int lastIndex = str.length() - 1;

for (int i = beginIdx; i < str.length(); i++) {
final char ch = str.charAt(i);

if(i == lastIndex && (ch == 'f' || ch == 'F' || ch == 'd' || ch == 'D')){
return true;
}

final boolean isDecimalPoint = ch == '.';
if (isDecimalPoint) {
decimalPoints++;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,8 +1028,8 @@ void testIsParsable() {
assertTrue(NumberUtils.isParsable("-018.2"));
assertTrue(NumberUtils.isParsable("-.236"));
assertTrue(NumberUtils.isParsable("2."));
// TODO assertTrue(NumberUtils.isParsable("2.f"));
// TODO assertTrue(NumberUtils.isParsable("2.d"));
assertTrue(NumberUtils.isParsable("2.f"));
assertTrue(NumberUtils.isParsable("2.d"));
}

/**
Expand Down