replace TYPE_ORIENTATION and handle screen orientation for Android#89
Open
shenzhuxi wants to merge 1 commit intoapache:masterfrom
Open
replace TYPE_ORIENTATION and handle screen orientation for Android#89shenzhuxi wants to merge 1 commit intoapache:masterfrom
shenzhuxi wants to merge 1 commit intoapache:masterfrom
Conversation
https://github.com/CompassMB/MBCompass/blob/main/app/src/main/java/com/mubarak/mbcompass/sensor/AndroidSensorEventListener.kt rewrite native code to replace TYPE_ORIENTATION with TYPE_ACCELEROMETER & TYPE_MAGNETIC_FIELD handle screen orientation apache#51 use TYPE_GRAVITY solve compass orientation difference for tilted screen (MBCompass missed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
#78 gave sinHeading and cosHeading instead of heading like the original plugin.
Description
So, I followed https://github.com/CompassMB/MBCompass replaced deprecated Sensor.TYPE_ORIENTATION.
It also handled the screen orientation issue with remapCoordinateSystem. #51
MBCompass behave differently from most map apps - the compass orientation is based on the device orientation and different when the screen tilts forward/backward.
So, I used TYPE_GRAVITY to detect the screen pitch orientation. As long as you don't use the screen heading to the ground (negative pitch), the plugin's behave should be the same as Google Map.
Testing
Samsung Galaxy Tab S5 and Pixel 7a
Checklist
(platform)if this change only applies to one platform (e.g.(android))