CB-5202 fix from lubogospod #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a daft question, but why does this use .avi? I thought the Android camera returned either 3gp or mp4 files. |
Member
|
Actually, you're right. Android generally returns 3gp and mp4 files. Returning an AVI container may mess things up. |
Contributor
|
bump |
Contributor
Contributor
|
The AVI issue is partially dealt with by #28, BTW. |
ath0mas
added a commit
to ath0mas/cordova-plugin-media-capture
that referenced
this pull request
Nov 6, 2021
see apache#210, and follow doc https://developer.android.com/training/camera/videobasics#TaskVideoView (removes partial changes done in apache#13 for old android and cordova versions)
ath0mas
added a commit
to ath0mas/cordova-plugin-media-capture
that referenced
this pull request
Jul 30, 2023
see apache#210, and follow doc https://developer.android.com/training/camera/videobasics#TaskVideoView (removes partial changes done in apache#13 for old android and cordova versions)
erisu
pushed a commit
that referenced
this pull request
Aug 3, 2023
…File (#232) * fix(android): standard way to get video uri from intent see #210, and follow doc https://developer.android.com/training/camera/videobasics#TaskVideoView (removes partial changes done in #13 for old android and cordova versions) * style(android): cleanup imports and remove unused method * fix(android): prevent NPE with null checks on intent data and mediaFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that #8 was closed prematurely. This fix is needed for Video record on Nexus 4.3 devices. I don't think lubogospod needs a CLA since this is pretty much just null fencing.