fix: native error message not propagated to SparkException on empty errorClass#3727
Conversation
|
@parthchandra Please help review when you are free. |
|
The original issue references a test failing, are we passing that now? Do we need to make any changes to the test (are we skipping it?) |
|
@mbutrovich The failure was from previous commit of #2897, not on the main branch. |
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
This change is fine. It would be good to know what the root cause of the failure was and to ensure that the error is actually handled correctly in native.
|
@mbutrovich @parthchandra Any more comments? |
|
@manuzhang approved, but can you tell us what failure resulted in an empty error class? |
|
@parthchandra Thanks for review. I tagged you in https://github.com/apache/datafusion-comet/pull/2897/changes#r2978425219 for the failure case. |
|
Merged. Thank you. @manuzhang |
3 participants
Closes #3726.