fix: Add schema validation for native_datafusion Parquet scan#3902
Open
vaibhawvipul wants to merge 2 commits intoapache:mainfrom
Open
fix: Add schema validation for native_datafusion Parquet scan#3902vaibhawvipul wants to merge 2 commits intoapache:mainfrom
vaibhawvipul wants to merge 2 commits intoapache:mainfrom
Conversation
vaibhawvipul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3720 .
Rationale for this change
The native_datafusion Parquet scan path silently produces wrong results or misses errors when the read schema is incompatible with the actual file schema. Spark's vectorized reader throws SchemaColumnConvertNotSupportedException for these cases (e.g., reading binary as timestamp, reading a scalar as an array, decimal precision mismatches), but Comet's native scan bypassed these checks entirely.
What changes are included in this PR?
Adds per-file Parquet schema validation to both scan paths (CometNativeScanExec and CometScanExec) by reading each file's footer and checking columns against the read schema
How are these changes tested?
all expected tests in the issue, pass.