Replace ReferentialAction enum in DROP statements#1648
Merged
iffyio merged 1 commit intoapache:mainfrom Jan 8, 2025
Merged
Conversation
iffyio
approved these changes
Jan 8, 2025
Contributor
iffyio
left a comment
There was a problem hiding this comment.
Thanks @stepancheg! This improvement sounds reasonable to me!
cc @alamb
ReferentialAction enum in DROP statements
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's
<drop behavior>definition in the grammar, so corresponding enum seems appropriate:vs
Context:
ALTER TABLE DROP COLUMNsqlparser does not supportRESTRICT. I wanted to add it, but addingReferentialActionthere too might be misleading, so here I introduce an enum.