Resolve breaking change that set "supports_lambda_functions" on GenericDialect#2224
Merged
iffyio merged 1 commit intoapache:mainfrom Feb 19, 2026
Merged
Conversation
iffyio
approved these changes
Feb 19, 2026
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @alexander-beedie!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2149 set "supports_lambda_functions" true for
DuckDbDialect(which is fine), but also (accidentally?) set it forGenericDialectas well, breaking the existing use of->as a binary operator.This was previously identified in #1686 (comment) as something that shouldn't be done; the
->operator should remain a binary operator inGenericDialect.This PR keeps the
DuckDbDialectaddition, reverts the change toGenericDialect, and adds a line of additional coverage to try and prevent any future regression.