Prefer use of peek_token_ref over peek_token where valid#2225
Merged
iffyio merged 1 commit intoapache:mainfrom Feb 20, 2026
Merged
Prefer use of peek_token_ref over peek_token where valid#2225iffyio merged 1 commit intoapache:mainfrom
peek_token_ref over peek_token where valid#2225iffyio merged 1 commit intoapache:mainfrom
Conversation
iffyio
approved these changes
Feb 20, 2026
Contributor
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @alexander-beedie!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started looking at performance optimisation opportunities that don't require structural or API changes - have identified several, and will make a series of PRs that each cover one change, to keep things clean/focused and easy to review.
Hopefully there will be a nice cumulative impact 👍
Description
Where valid, the following updates have been made to avoid unnecessary clones, by preferring the "ref" variant of several core parsing functions:
peek_token→peek_token_ref(~200 updates)expected→expected_ref(~100 updates)Results
Local testing with
sqlparser_benchtests showed the following improvements: