Add support for INTERVAL keyword as unquoted identifier in PostgreSQL#2238
Merged
yoavcloud merged 1 commit intoapache:mainfrom Feb 25, 2026
Merged
Add support for INTERVAL keyword as unquoted identifier in PostgreSQL#2238yoavcloud merged 1 commit intoapache:mainfrom
yoavcloud merged 1 commit intoapache:mainfrom
Conversation
yoavcloud
approved these changes
Feb 25, 2026
LucaCappelletti94
added a commit
to LucaCappelletti94/sqlparser-rs
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a PostgreSQL dialect parsing bug where
INTERVALwas always treated as a reserved identifier keyword, causing valid queries such as:to fail with
Expected: an expression, found: ).Problem
In PostgreSQL, interval can be used as an unquoted identifier in unambiguous expression positions (for example function arguments). Our parser attempted INTERVAL-literal parsing first, and on failure it only fell back to identifier parsing when the keyword is not reserved. Because INTERVAL was reserved for
PostgreSqlDialect, fallback was blocked.Fix
is_reserved_for_identifiersoKeyword::INTERVALis not treated as reserved in this dialect.Tests
Added regression test in PostgreSQL-specific suite:
SELECT MAX(interval) FROM tblnow parses successfully in PostgreSqlDialect.INTERVAL '1 day'still parses as an interval expression (guarding against regressions).Impact