PostgreSQL RETURNS SETOF Support in CREATE FUNCTION#2258
Closed
LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
Closed
PostgreSQL RETURNS SETOF Support in CREATE FUNCTION#2258LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
RETURNS SETOF Support in CREATE FUNCTION#2258LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
Conversation
Add a dedicated SETOF data type wrapper in the AST, teach the PostgreSQL CREATE FUNCTION parser to wrap return types after RETURNS SETOF, and register SETOF in the keyword table so parsing no longer relies on raw NoKeyword text matching.
Cover SETOF UUID function declarations for no-arg, parameterized, and array/unnest bodies, and assert return_type/language/behavior in the parsed AST.
Contributor
|
a note, there's an ongoing PR related to this feature #2217 |
Contributor
Author
|
Closing as there already PR #2217 covering the same set of functionalities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL allows function declarations like
RETURNS SETOF UUID, but previously failed to parse that form and produced:Expected: end of statement, found: UUIDNow statements like:
CREATE FUNCTION any_ids() RETURNS SETOF UUID ...CREATE FUNCTION ids_for_user(p_user_id UUID) RETURNS SETOF UUID ...CREATE FUNCTION ids_from_array() RETURNS SETOF UUID ...parse successfully under
PostgreSqlDialect.