Skip to content

refactor: remove useless conversion in StringSerde #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proost merged 1 commit into from
Mar 6, 2026
Merged

refactor: remove useless conversion in StringSerde #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions common/item_sketch_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ func (f ItemSketchStringHasher) Hash(item string) uint64 {
}

func (f ItemSketchStringSerDe) SizeOf(item string) int {
if len(item) == 0 {
return int(unsafe.Sizeof(uint32(0)))
}
return len(item) + int(unsafe.Sizeof(uint32(0)))
return len(item) + 4
}

func (f ItemSketchStringSerDe) SizeOfMany(mem []byte, offsetBytes int, numItems int) (int, error) {
Expand Down Expand Up @@ -77,28 +74,25 @@ func (f ItemSketchStringSerDe) SerializeOneToSlice(item string) []byte {
utf8len := len(item)
bytesOut := make([]byte, utf8len+4)
binary.LittleEndian.PutUint32(bytesOut, uint32(utf8len))
copy(bytesOut[4:], []byte(item))
copy(bytesOut[4:], item)
return bytesOut
}

func (f ItemSketchStringSerDe) SerializeManyToSlice(item []string) []byte {
if len(item) == 0 {
func (f ItemSketchStringSerDe) SerializeManyToSlice(items []string) []byte {
if len(items) == 0 {
return []byte{}
}
totalBytes := 0
numItems := len(item)
serialized2DArray := make([][]byte, numItems)
for i := 0; i < numItems; i++ {
serialized2DArray[i] = []byte(item[i])
totalBytes += len(serialized2DArray[i]) + 4
for _, item := range items {
totalBytes += len(item) + 4
}
bytesOut := make([]byte, totalBytes)
offset := 0
for i := 0; i < numItems; i++ {
utf8len := len(serialized2DArray[i])
for _, item := range items {
utf8len := len(item)
binary.LittleEndian.PutUint32(bytesOut[offset:], uint32(utf8len))
offset += 4
copy(bytesOut[offset:], serialized2DArray[i])
copy(bytesOut[offset:], item)
offset += utf8len
}
return bytesOut
Expand All @@ -110,7 +104,7 @@ func (f ItemSketchStringSerDe) DeserializeManyFromSlice(mem []byte, offsetBytes
}
array := make([]string, numItems)
offset := offsetBytes
intSize := int(unsafe.Sizeof(uint32(0)))
intSize := 4
memCap := len(mem)
for i := 0; i < numItems; i++ {
if !checkBounds(offset, intSize, memCap) {
Expand Down
Loading
Loading