Skip to content

[hotfix] toolCallContext not updated in ChatModelAction, causing data loss #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

[hotfix] toolCallContext not updated in ChatModelAction, causing data loss #289

merged 1 commit into from
Oct 31, 2025

Conversation

@GreatEugenius
Copy link
Collaborator

@GreatEugenius GreatEugenius commented Oct 29, 2025 •
edited
Loading

Linked issue: #288

Purpose of change

This fix ensures that the updated messageContext is properly stored in toolCallContext before setting it in the ShortTermMemory.

Tests

API

Documentation

Cherrypick

No

@GreatEugenius
Copy link
Collaborator Author

GreatEugenius commented Oct 29, 2025

@xuannan @wenjin272 please help take a look this PR, thanks.

@wenjin272
Copy link
Collaborator

wenjin272 commented Oct 29, 2025

LGTM.
This is caused by pr #279, which is merged after 0.1.0 release, so there is no need to cp to branch release-0.1.

@Sxnan
Copy link
Contributor

Sxnan commented Oct 31, 2025

LGTM

@Sxnan Sxnan merged commit da299d9 into apache:main Oct 31, 2025
11 checks passed
@Sxnan Sxnan added priority/major Default priority of the PR or issue. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. doc-not-needed Your PR changes do not impact docs labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenjin272 wenjin272 Awaiting requested review from wenjin272

@Sxnan Sxnan Awaiting requested review from Sxnan

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GreatEugenius @wenjin272 @Sxnan