Skip to content

[hotfix] Adapt ollama example after supporting explicit tool call handling in OllamaChatModel. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[hotfix] Adapt ollama example after supporting explicit tool call handling in OllamaChatModel. #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bada53
[hotfix] Increase request timeout in ollama test to avoid read timeou…
wenjin272 Oct 31, 2025
e083898
[hotfix] Adapt ollama example after supporting explicit tool call han…
wenjin272 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...egration-test/src/main/java/org/apache/flink/agents/integration/test/AgentWithOllama.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import org.apache.flink.agents.api.chat.messages.MessageRole;
import org.apache.flink.agents.api.chat.model.BaseChatModelSetup;
import org.apache.flink.agents.api.context.RunnerContext;
import org.apache.flink.agents.api.event.ChatRequestEvent;
import org.apache.flink.agents.api.event.ChatResponseEvent;
import org.apache.flink.agents.api.resource.ResourceDescriptor;
import org.apache.flink.agents.api.resource.ResourceType;
import org.apache.flink.agents.integrations.chatmodels.ollama.OllamaChatModelConnection;
Expand Down Expand Up @@ -126,10 +128,15 @@ public static double createRandomNumber() {
public static void process(InputEvent event, RunnerContext ctx) throws Exception {
BaseChatModelSetup chatModel =
(BaseChatModelSetup) ctx.getResource("ollamaChatModel", ResourceType.CHAT_MODEL);
ChatMessage response =
chatModel.chat(
ctx.sendEvent(
new ChatRequestEvent(
"ollamaChatModel",
Collections.singletonList(
new ChatMessage(MessageRole.USER, (String) event.getInput())));
ctx.sendEvent(new OutputEvent(response.getContent()));
new ChatMessage(MessageRole.USER, (String) event.getInput()))));
}

@Action(listenEvents = {ChatResponseEvent.class})
public static void processChatResponse(ChatResponseEvent event, RunnerContext ctx) {
ctx.sendEvent(new OutputEvent(event.getResponse().getContent()));
}
}
4 changes: 2 additions & 2 deletions python/flink_agents/integrations/chat_models/tests/test_ollama_chat_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
client is None, reason="Ollama client is not available or test model is missing"
)
def test_ollama_chat() -> None: # noqa :D103
server = OllamaChatModelConnection(name="ollama")
server = OllamaChatModelConnection(name="ollama", request_timeout=120.0)
response = server.chat(
[ChatMessage(role=MessageRole.USER, content="Hello!")], model=test_model
)
Expand Down Expand Up @@ -94,7 +94,7 @@ def get_tool(name: str, type: ResourceType) -> FunctionTool: # noqa :D103
client is None, reason="Ollama client is not available or test model is missing"
)
def test_ollama_chat_with_tools() -> None: # noqa :D103
connection = OllamaChatModelConnection(name="ollama")
connection = OllamaChatModelConnection(name="ollama", request_timeout=120.0)

def get_resource(name: str, type: ResourceType) -> Resource:
if type == ResourceType.TOOL:
Expand Down