Skip to content

[FLINK-38479] Problems after upgrading the operator from 1.12.1 to 1.13.0 #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

[FLINK-38479] Problems after upgrading the operator from 1.12.1 to 1.13.0 #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...main/java/org/apache/flink/kubernetes/operator/reconciler/diff/ReflectiveDiffBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,14 @@ private void appendFields(final Class<?> clazz) {
var leftField = readField(field, before, true);
var rightField = readField(field, after, true);
if (field.getName().equals(FLINK_CONFIGURATION_PROPERTY_NAME)) {
leftField = ((ConfigObjectNode) leftField).asFlatMap();
rightField = ((ConfigObjectNode) rightField).asFlatMap();
leftField =
leftField == null
? null
: ((ConfigObjectNode) leftField).asFlatMap();
rightField =
rightField == null
? null
: ((ConfigObjectNode) rightField).asFlatMap();
}

if (field.isAnnotationPresent(SpecDiff.Config.class)
Expand Down
14 changes: 14 additions & 0 deletions ...ator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/diff/SpecDiffTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.flink.configuration.PipelineOptions;
import org.apache.flink.kubernetes.operator.TestUtils;
import org.apache.flink.kubernetes.operator.api.diff.DiffType;
import org.apache.flink.kubernetes.operator.api.spec.ConfigObjectNode;
import org.apache.flink.kubernetes.operator.api.spec.FlinkDeploymentSpec;
import org.apache.flink.kubernetes.operator.api.spec.FlinkSessionJobSpec;
import org.apache.flink.kubernetes.operator.api.spec.FlinkVersion;
Expand Down Expand Up @@ -402,6 +403,19 @@ public void testSavepointNonceDiff() {
assertEquals(0, diff.getNumDiffs());
}

@Test
public void testNullFlinkConfiguration() {
var left = new FlinkDeploymentSpec();
left.setFlinkConfiguration((ConfigObjectNode) null);
var right = new FlinkDeploymentSpec();

// This should fail with NullPointerException because there's no null check
// in ReflectiveDiffBuilder when casting flinkConfiguration to ConfigObjectNode
var diff =
new ReflectiveDiffBuilder<>(KubernetesDeploymentMode.NATIVE, left, right).build();
assertEquals(DiffType.IGNORE, diff.getType());
}

@Value
private static class TestClass {
boolean[] f0;
Expand Down
Loading