-
Notifications
You must be signed in to change notification settings - Fork 478
[hotfix] Move delta join to common catalog and source ItCase. #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
FYI, my PR #2268 also adds tests to Flink22TableSourceITCase. |
|
@fresh-borzoni Thanks a lot. It seems your code still need @xuyangzhong to review, maybe my tiny modification can be merged first, then you can rebase it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This hotfix moves delta join tests and index-related catalog tests from Flink 2.2-specific test classes to the common test base classes. The change enables these tests to run conditionally based on index support via SchemaAdapter.supportIndex(), allowing the tests to be shared across different Flink versions while maintaining version-specific behavior through subclass overrides.
Key changes:
- Three delta join test methods moved from
Flink22TableSourceITCasetoFlinkTableSourceITCase - Index catalog test method moved from
Flink22CatalogITCasetoFlinkCatalogITCase - Added
supportIndex()method to base test classes (returnsfalse) and Flink 2.2 subclasses (returnstrue)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| FlinkTableSourceITCase.java | Added three delta join test methods (testDeltaJoin, testDeltaJoinWithProjectionAndFilter, testDeltaJoinWithLookupCache) and supportIndex() method to the common base class with assumptions checking SchemaAdapter.supportIndex() |
| FlinkCatalogITCase.java | Added testGetTableWithIndex() test method and supportIndex() method to the common base class with assumptions checking SchemaAdapter.supportIndex() |
| Flink22TableSourceITCase.java | Removed three delta join test methods and added supportIndex() override returning true |
| Flink22CatalogITCase.java | Removed testGetTableWithIndex() test method, added supportIndex() override returning true, and removed trailing whitespace in addDefaultIndexKey() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...k/fluss-flink-common/src/test/java/org/apache/fluss/flink/source/FlinkTableSourceITCase.java
Show resolved
Hide resolved
...k/fluss-flink-common/src/test/java/org/apache/fluss/flink/source/FlinkTableSourceITCase.java
Show resolved
Hide resolved
...k/fluss-flink-common/src/test/java/org/apache/fluss/flink/source/FlinkTableSourceITCase.java
Show resolved
Hide resolved
...k/fluss-flink-common/src/test/java/org/apache/fluss/flink/source/FlinkTableSourceITCase.java
Outdated
Show resolved
Hide resolved
...link/fluss-flink-common/src/test/java/org/apache/fluss/flink/catalog/FlinkCatalogITCase.java
Outdated
Show resolved
Hide resolved
...flink/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/catalog/Flink22CatalogITCase.java
Show resolved
Hide resolved
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
6023bce to
cd80020
Compare
Purpose
Linked issue: Move delta join to common catalog and source ItCase.
Brief change log
Tests
API and Format
Documentation