Skip to content

Conversation

@loserwang1024
Copy link
Contributor

Purpose

Linked issue: Move delta join to common catalog and source ItCase.

Brief change log

Tests

API and Format

Documentation

@fresh-borzoni
Copy link

FYI, my PR #2268 also adds tests to Flink22TableSourceITCase.
Should mine merge first, or should I rebase after this?

@loserwang1024
Copy link
Contributor Author

@fresh-borzoni Thanks a lot. It seems your code still need @xuyangzhong to review, maybe my tiny modification can be merged first, then you can rebase it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This hotfix moves delta join tests and index-related catalog tests from Flink 2.2-specific test classes to the common test base classes. The change enables these tests to run conditionally based on index support via SchemaAdapter.supportIndex(), allowing the tests to be shared across different Flink versions while maintaining version-specific behavior through subclass overrides.

Key changes:

  • Three delta join test methods moved from Flink22TableSourceITCase to FlinkTableSourceITCase
  • Index catalog test method moved from Flink22CatalogITCase to FlinkCatalogITCase
  • Added supportIndex() method to base test classes (returns false) and Flink 2.2 subclasses (returns true)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
FlinkTableSourceITCase.java Added three delta join test methods (testDeltaJoin, testDeltaJoinWithProjectionAndFilter, testDeltaJoinWithLookupCache) and supportIndex() method to the common base class with assumptions checking SchemaAdapter.supportIndex()
FlinkCatalogITCase.java Added testGetTableWithIndex() test method and supportIndex() method to the common base class with assumptions checking SchemaAdapter.supportIndex()
Flink22TableSourceITCase.java Removed three delta join test methods and added supportIndex() override returning true
Flink22CatalogITCase.java Removed testGetTableWithIndex() test method, added supportIndex() override returning true, and removed trailing whitespace in addDefaultIndexKey() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@loserwang1024 loserwang1024 force-pushed the refractor-catalog-test branch from 6023bce to cd80020 Compare January 5, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants