feat(java): implement FinalFieldReplaceResolveSerializer for final fields with writeReplace/readResolve methods #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds with writeReplace/readResolve methods. This helps to avoid writing class names for final fields to the payload.
…ing descriptor context
… fields with writeReplace/readResolve methods
…t for final fields
Author
|
@chaokunyang re-created my PR, addressed your comments in slack, please check |
chaokunyang
reviewed
Nov 17, 2025
| if (JavaSerializer.getWriteReplaceMethod(cls) != null) { | ||
| return ReplaceResolveSerializer.class; | ||
| if (!fory.isCompatible() && !fory.isShareMeta() && Modifier.isFinal(cls.getModifiers())) { | ||
| return FinalFieldReplaceResolveSerializer.class; |
Collaborator
There was a problem hiding this comment.
I don't think we can return this here? If FinalFieldReplaceResolveSerializer don't write class info, and fory don't write class into, then for deserialization, how do we know which class to use to create object instance?
Collaborator
There was a problem hiding this comment.
FinalFieldReplaceResolveSerializer can only be used for field serializer, and getSerializerClass is used for non-field object serialization too.
Another thing is that this change make all tests pass, it should not. We may need add a test to cover this
chaokunyang
reviewed
Nov 17, 2025
java/fory-core/src/main/java/org/apache/fory/serializer/AbstractObjectSerializer.java
Outdated
Show resolved
Hide resolved
…dling in serializers. Add a cache for final fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Based on the discussion #2786.
We can optimize the payload in cases where we have final fields in some Object.
re-created, closed PR #2904
What does this PR do?
Introduce
FinalFieldReplaceResolverwhich does not write the classname into the payload.Related issues
Does this PR introduce any user-facing change?
Benchmark