-
Notifications
You must be signed in to change notification settings - Fork 16
GEODE-10474: Update logomark after ASF rebrand #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GEODE-10474: Project website does not reflect updated branding The ASF recently launched a new brand and visual identity, which incudes a new logomark. This commit replaces the former logomark on the Geode project home page with the new one in order to comply with ASF brand guidelines. It also updates the copyright year to 2025. Signed-off-by: Bryan Behrenshausen <bryan.behrenshausen@sas.com>
|
Unfortunately I'm unable to assign reviewers, so I will just lightly tap @nitin-amp, @raboof, and @JinwooHwang to have a look when they're able. |
JinwooHwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @semioticrobotic
|
@nitin-amp and @raboof. Any comments or suggestions? Thanks. |
LGTM! |
|
Thank you both, @nitin-amp and @JinwooHwang. I've reviewed the appropriate logs, but unfortunately I am not savvy enough to diagnose the error that is causing that single test to fail. |
It seems to be unrelated to this change - some license file may be the culprit, which is failing |
|
Thank you so much @nitin-amp |
|
Yikes! Thanks so much for tracing that down, @raboof. In this case, what do you recommend to appease the plugin and remain in compliance? |
|
I'd first try if updating the plugin to the newest version helps. If not (I'd say it's a 50/50 chance), I'd look into if it's easy to add the license to the SVG, and if not how to exclude it from Rat in the Gradle config. |
This makes sense to me, @raboof. But I'm afraid testing these solutions is a bit beyond my abilities. @nitin-amp, do you think you could help me? |
|
Spoke with @nitin-amp on a call today, and he has graciously agreed to take a look at this and help me along. |
Thanks for your patience while I updated my dev environment! I'm able to get past this error by adding the 1 line in // graphics
'website/content/docs/guide/**/*.svg',
'website/content/img/**/*.svg',This would tell the rat plugin to ignore the new svg logo file in |
|
That seems reasonable. Did upgrading the Rat plugin version to 0.8.1 not help? Might be good to do that anyway :) |
Not sure how complicated that would be. What do you think, @nitin-amp? |
I did not upgrade rat; this is an expected config edit for such non-binary images. Don't think it would be that complicated to update the rat version. I thought it would be worth waiting for Java 17 updates, as well as decision to update the template. If the project moves to another website stack, say docusaurus (node-based), this would be short-lived. |
|
All makes sense to me. Thanks, @nitin-amp! |
This commit adds an additional graphics exclusion to the build.gradle file in order to clear an error thrown on builds. Signed-off-by: Bryan Behrenshausen <bryan.behrenshausen@sas.com>
|
@JinwooHwang or @nitin-amp: Any chance you could kick-start the checks once again to see if that change clears the error? |
|
Pulled the trigger for you @semioticrobotic |
|
Great! This appears to be passing now, @JinwooHwang. |
GEODE-10474: Project website does not reflect updated branding
The ASF recently launched a new brand and visual identity, which incudes a new logomark. This commit replaces the former logomark on the Geode project home page with the new one in order to comply with ASF brand guidelines. It also updates the copyright year to 2025.