Skip to content

Conversation

@semioticrobotic
Copy link
Contributor

GEODE-10474: Project website does not reflect updated branding

The ASF recently launched a new brand and visual identity, which incudes a new logomark. This commit replaces the former logomark on the Geode project home page with the new one in order to comply with ASF brand guidelines. It also updates the copyright year to 2025.

GEODE-10474: Project website does not reflect updated branding

The ASF recently launched a new brand and visual identity, which incudes
a new logomark. This commit replaces the former logomark on the Geode
project home page with the new one in order to comply with ASF brand
guidelines. It also updates the copyright year to 2025.

Signed-off-by: Bryan Behrenshausen <bryan.behrenshausen@sas.com>
@semioticrobotic
Copy link
Contributor Author

Unfortunately I'm unable to assign reviewers, so I will just lightly tap @nitin-amp, @raboof, and @JinwooHwang to have a look when they're able.

@JinwooHwang JinwooHwang self-requested a review September 22, 2025 15:15
Copy link
Contributor

@JinwooHwang JinwooHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @semioticrobotic

@JinwooHwang
Copy link
Contributor

@nitin-amp and @raboof. Any comments or suggestions? Thanks.

@nitin-amp
Copy link

@nitin-amp and @raboof. Any comments or suggestions? Thanks.

LGTM!

@semioticrobotic
Copy link
Contributor Author

Thank you both, @nitin-amp and @JinwooHwang. I've reviewed the appropriate logs, but unfortunately I am not savvy enough to diagnose the error that is causing that single test to fail.

@nitin-amp
Copy link

Thank you both, @nitin-amp and @JinwooHwang. I've reviewed the appropriate logs, but unfortunately I am not savvy enough to diagnose the error that is causing that single test to fail.

It seems to be unrelated to this change - some license file may be the culprit, which is failing rat. I can take a look later in the week.

@JinwooHwang
Copy link
Contributor

Thank you so much @nitin-amp

@raboof
Copy link
Member

raboof commented Sep 23, 2025

  • It is pretty annoying that the Gradle Rat plugin doesn't show which file violated the rule. Geode uses a pretty old version of the plugin (0.3.0). A newer version (0.8.1) is available (https://plugins.gradle.org/plugin/org.nosphere.apache.rat), perhaps that gives better feedback?

  • I tried running locally, which revealed that the file with missing license information is actually website/content/img/asf_logo.svg. Apparently 'png' is not checked because it is 'binary', but 'svg' it checked because it is 'text'(like). I wonder if the newest version of the Gradle Rat plugin is also so strict ;)

@semioticrobotic
Copy link
Contributor Author

  • It is pretty annoying that the Gradle Rat plugin doesn't show which file violated the rule. Geode uses a pretty old version of the plugin (0.3.0). A newer version (0.8.1) is available (https://plugins.gradle.org/plugin/org.nosphere.apache.rat), perhaps that gives better feedback?

    • I tried running locally, which revealed that the file with missing license information is actually website/content/img/asf_logo.svg. Apparently 'png' is not checked because it is 'binary', but 'svg' it checked because it is 'text'(like). I wonder if the newest version of the Gradle Rat plugin is also so strict ;)

Yikes! Thanks so much for tracing that down, @raboof. In this case, what do you recommend to appease the plugin and remain in compliance?

@raboof
Copy link
Member

raboof commented Sep 23, 2025

I'd first try if updating the plugin to the newest version helps. If not (I'd say it's a 50/50 chance), I'd look into if it's easy to add the license to the SVG, and if not how to exclude it from Rat in the Gradle config.

@semioticrobotic
Copy link
Contributor Author

I'd first try if updating the plugin to the newest version helps. If not (I'd say it's a 50/50 chance), I'd look into if it's easy to add the license to the SVG, and if not how to exclude it from Rat in the Gradle config.

This makes sense to me, @raboof. But I'm afraid testing these solutions is a bit beyond my abilities. @nitin-amp, do you think you could help me?

@semioticrobotic
Copy link
Contributor Author

Spoke with @nitin-amp on a call today, and he has graciously agreed to take a look at this and help me along.

@nitin-amp
Copy link

nitin-amp commented Sep 26, 2025

Spoke with @nitin-amp on a call today, and he has graciously agreed to take a look at this and help me along.

Thanks for your patience while I updated my dev environment!

I'm able to get past this error by adding the 1 line in // graphics excludes in the rat config section of build.gradle file:

    // graphics
    'website/content/docs/guide/**/*.svg',
    'website/content/img/**/*.svg',

This would tell the rat plugin to ignore the new svg logo file in website/content/img folder, as correctly pointed by @raboof (Thanks!)

@raboof
Copy link
Member

raboof commented Sep 26, 2025

That seems reasonable. Did upgrading the Rat plugin version to 0.8.1 not help? Might be good to do that anyway :)

@semioticrobotic
Copy link
Contributor Author

That seems reasonable. Did upgrading the Rat plugin version to 0.8.1 not help? Might be good to do that anyway :)

Not sure how complicated that would be. What do you think, @nitin-amp?

@nitin-amp
Copy link

That seems reasonable. Did upgrading the Rat plugin version to 0.8.1 not help? Might be good to do that anyway :)

Not sure how complicated that would be. What do you think, @nitin-amp?

I did not upgrade rat; this is an expected config edit for such non-binary images.

Don't think it would be that complicated to update the rat version. I thought it would be worth waiting for Java 17 updates, as well as decision to update the template. If the project moves to another website stack, say docusaurus (node-based), this would be short-lived.

@semioticrobotic
Copy link
Contributor Author

All makes sense to me. Thanks, @nitin-amp!

This commit adds an additional graphics exclusion to the build.gradle
file in order to clear an error thrown on builds.

Signed-off-by: Bryan Behrenshausen <bryan.behrenshausen@sas.com>
@semioticrobotic
Copy link
Contributor Author

@JinwooHwang or @nitin-amp: Any chance you could kick-start the checks once again to see if that change clears the error?

@JinwooHwang
Copy link
Contributor

Pulled the trigger for you @semioticrobotic

@semioticrobotic
Copy link
Contributor Author

Great! This appears to be passing now, @JinwooHwang.

@raboof raboof merged commit dfc0786 into apache:master Sep 27, 2025
1 check passed
@semioticrobotic semioticrobotic deleted the feature/GEODE-10474 branch September 29, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants