-
Notifications
You must be signed in to change notification settings - Fork 94
Change dependencies to compileOnly so they are not in POM or Gradle Module #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule Switched several dependencies from implementation/api to compileOnly. Disabled Grails springDependencyManagement and added testImplementation for grails-bom.
Contributor
Author
|
Contributor
Author
|
Bump Gradle wrapper version from 8.14.2 to 8.14.3 to use the latest features and fixes.
jdaugherty
reviewed
Oct 2, 2025
Bumps the Gradle version from 8.14.2 to 8.14.3 for local development environment configuration.
Reorganized and simplified dependency declarations by removing individual compileOnly and testImplementation entries in favor of 'grails-dependencies-starter-web' and 'grails-dependencies-test'. This streamlines dependency management and reduces redundancy.
jamesfredley
commented
Oct 8, 2025
Updated build.gradle to use implementation platform for Grails BOM and removed redundant platform declarations. Also removed the unused quartzVersion property from gradle.properties, as the version is now managed by the BOM.
jdaugherty
approved these changes
Oct 8, 2025
Contributor
jdaugherty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately from this PR: we should open a ticket to create an example project to better test this going forward. We can restructure the repo at the same time.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched several dependencies from implementation/api to compileOnly. Disabled Grails springDependencyManagement and added testImplementation for grails-bom.
Switched to
grails-dependencies-starter-webandgrails-dependencies-testdependencies to simplifyresolves: #158