HIVE-29470: Add unit test to verify commonLocalResources after openin…#6338
Merged
abstractdog merged 1 commit intoapache:masterfrom Mar 4, 2026
Merged
HIVE-29470: Add unit test to verify commonLocalResources after openin…#6338abstractdog merged 1 commit intoapache:masterfrom
abstractdog merged 1 commit intoapache:masterfrom
Conversation
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
abstractdog
reviewed
Mar 3, 2026
| HiveConf hiveConf = new HiveConfForTest(getClass()); | ||
| hiveConf.set("hive.security.authorization.manager", | ||
| "org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdConfOnlyAuthorizerFactory"); | ||
| SessionState.start(hiveConf); |
Contributor
There was a problem hiding this comment.
start method returns the SessionState object with can be used later instead of SessionState.get(): while this also work, the object is better to be seen clearly here, instead of relying on the whole ThreadLocal magic of the SessionState universe
Contributor
Author
There was a problem hiding this comment.
Addressed the issue and also added common method to reuse for all test cases.
Contributor
|
thanks @kokila-19 , looks good to me, I only had a minor comment |
…g a Tez session Ensures buildCommonLocalResources populates the map with the hive-exec app jar and localized resources so regressions are caught if resource registration is removed.
kokila-19
force-pushed
the
jar_localization
branch
from
01f2f02 to
f607295
Compare
|
Contributor
|
LGTM, using |
abstractdog
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g a Tez session
Ensures buildCommonLocalResources populates the map with the hive-exec app jar and localized resources so regressions are caught if resource registration is removed.
What changes were proposed in this pull request?
Added testCommonLocalResourcesPopulatedOnSessionOpen() to assert that commonLocalResources includes:
the hive-exec app jar and all localized resources when opening a Tez session.
Why are the changes needed?
Resource registration in openInternalUnsafe (adding the app jar and localized resources to commonLocalResources) had no test coverage. Because of that, tests still passed when that registration was removed or commented out, so a regression could go undetected.
This PR adds unit test coverage so that if the commonLocalResources.put() calls for the app jar or localized resources are removed, the new test fails and the regression is caught.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test