HIVE-29478: FileSinkOperator shouldn't check for isMMTable for everyrow being processed#6341
Open
nareshpr wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29478: FileSinkOperator shouldn't check for isMMTable for everyrow being processed#6341nareshpr wants to merge 1 commit intoapache:masterfrom
nareshpr wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@nareshpr : approved, but I've just realized there are a few more occurrences of |
Contributor
Author
|
yes, i will remove all Map conversion in AcidUtils. |
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests failed
tests pending
tests unstable
labels
Contributor
Author
|
@abstractdog I had done the changes, can you please review ? |
Contributor
please take care of the sonarqube warnings (unused imports), other than that, looks good to me |
…row being processed
|
Contributor
Author
|
Taken care of checkstyle unused import. Got successful green build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
conf.isMMTable() shouldn't be invoked for every row being processed. This came up as hotspot in ETL file write flow.
Why are the changes needed?
It improves write performance, specifically properties to map conversion is not required to validate a single property for every row being processed.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tests were not added, as its performance improvement.