Skip to content

fix: clang-tidy in cpplint should compile header files in C++23 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Nov 28, 2025
Merged

fix: clang-tidy in cpplint should compile header files in C++23 #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/cpp-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ on:
jobs:
cpp-linter:
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: write
Copy link
Member

@wgtmac wgtmac Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried this but it does not work. See discussion in #20 (comment)

Copy link
Contributor Author

@HuaHuaY HuaHuaY Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we remove thread-comments: true?

steps:
- name: Checkout iceberg-cpp
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
Expand Down Expand Up @@ -57,8 +60,9 @@ jobs:
thread-comments: true
ignore: 'build|cmake_modules|ci'
database: build
verbosity: 'debug'
Copy link
Member

@wgtmac wgtmac Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove this? Does it affect the run time?

Copy link
Contributor Author

@HuaHuaY HuaHuaY Nov 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will display detailed output when clang-tidy fails. I think it doesn't affect the run time.

# need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614
extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like'
extra-args: '-std=c++23 -I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like'
- name: Fail fast?!
if: steps.linter.outputs.checks-failed != 0
run: |
Expand Down
Loading