refactor: improve error collector #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refine function names to be consistent. - Add easy-to-use functions and macros.
wgtmac
force-pushed
the
refine_error_collector
branch
from
ffd4778 to
2a176fd
Compare
zhjwpku
approved these changes
Dec 20, 2025
Collaborator
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
LGTM, this will make the code shorter and cleaner.
liurenjie1024
approved these changes
Dec 22, 2025
Member
Author
|
Thanks @zhjwpku and @liurenjie1024! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the usability of
ErrorCollectorclass: