REST, OAuth2: OAuth2 AuthManager v2 - Part 1: Configuration#15703
Open
adutra wants to merge 1 commit intoapache:mainfrom
Open
REST, OAuth2: OAuth2 AuthManager v2 - Part 1: Configuration#15703adutra wants to merge 1 commit intoapache:mainfrom
adutra wants to merge 1 commit intoapache:mainfrom
Conversation
This is the first PR related to the "Auth Manager v2" effort. Cf. [design document]. This PR introduces the configuration layer changes (section 5.1 of the design doc). It also introduces a few class deprecations. The most important part is the migration of configuration properties. This is handled by `ConfigMigrator`. Its logic may seem complex, that's because we need to handle some edge cases, as detailed in the design doc, section 5.6. The most complex edge case is when a session context initiates a token exchange flow, using the catalog session's parent token as the actor token (a.k.a. the "Trino use case"): this is handled in v2 by introducing a special sentinel value that will be recognized and processed at runtime (this will come in a later PR though). Merging this PR has only one visible consequence: deprecation warnings will be printed when loading the legacy (v1) manager, and when any deprecated v1 configuration is used. [design document]:https://docs.google.com/document/d/1Hxw-t8Maa7wZFmrlSujm7LRawKsFP3Q31tET_3aRnQU/edit
Contributor
Author
|
FYI the full changes can be reviewed here for reference: #15704 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR related to the "Auth Manager v2" effort. Cf. design document.
This PR introduces the configuration layer changes (section 5.1 of the design doc). It also introduces a few class deprecations.
The most important part is the migration of configuration properties. This is handled by
ConfigMigrator. Its logic may seem complex, that's because we need to handle some edge cases, as detailed in the design doc, section 5.6. The most complex edge case is when a session context initiates a token exchange flow, using the catalog session's parent token as the actor token (a.k.a. the "Trino use case"): this is handled in v2 by introducing a special sentinel value that will be recognized and processed at runtime (this will come in a later PR though).Merging this PR has only one visible consequence: deprecation warnings will be printed when loading the legacy (v1) manager, and when any deprecated v1 configuration is used.