IGNITE-22530 CDC: Add regex filters for cache names #11503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgarrish
force-pushed
the
ignite-22530
branch
from
6133cfc to
f8ef9a2
Compare
lordgarrish
force-pushed
the
ignite-22530
branch
3 times, most recently
from
2addf31 to
a9ca469
Compare
lordgarrish
force-pushed
the
ignite-22530
branch
from
f3a2664 to
317c326
Compare
lordgarrish
force-pushed
the
ignite-22530
branch
from
317c326 to
5b0a904
Compare
NSAmelchev
reviewed
Oct 15, 2025
| /** | ||
| * Regexp matcher that processes user's regexp patterns for CDC caches names. | ||
| */ | ||
| public interface CdcRegexMatcher { |
Contributor
There was a problem hiding this comment.
Why do we need it in the core module?
Contributor
Author
There was a problem hiding this comment.
It could be a part of public API so that other users can implement their own matchers.
Contributor
There was a problem hiding this comment.
Users should implement their own CdcConsumer. The core module does not provide implementation details.
Contributor
Author
There was a problem hiding this comment.
It'a an interface similiar to CdcConsumer. CdcConsumer itself does not contain regexp matching logic, but it can have an instance of CdcRegexMatcher as a field variable to do it. Users can implement their own CdcRegexMatcher or use default implementation in cdc-ext module.
Contributor
There was a problem hiding this comment.
How is CdcRegexMatcher handled in the core module?
added 5 commits
November 3, 2025 18:44
lordgarrish
force-pushed
the
ignite-22530
branch
from
5b0a904 to
58d2fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds extended CdcConsumerEx interface with the possiblity of passing the path of CDC directory to implementation of CdcRegexMatcher in extensions. This commit is a counterpart to commit with the same name in ignite-extensions, and they both should be merged simultaneously.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.