-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19734: Updating the docs for KIP-1221 #20804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-19734: Updating the docs for KIP-1221 #20804
Conversation
bbejeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @gensericghiro, overall lgtm once we address the outstanding comment.
mjsax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a new bullet point to the upgrade guide.
bbejeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chia7712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Updating the docs for the client state metric as a follow up to #20766
Reviewers: Matthias Saxmjsax@apache.org, Bill
Bejeckbbejeck@apache.org, Chia-Ping Tsai chia7712@gmail.com