Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ public ClientRequest newClientRequest(String nodeId,
// visible for testing
int nextCorrelationId() {
if (SaslClientAuthenticator.isReserved(correlation)) {
// the numeric overflow is fine as negative values is acceptable
// the numeric overflow is fine as negative values are acceptable
correlation = SaslClientAuthenticator.MAX_RESERVED_CORRELATION_ID + 1;
}
return correlation++;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public KafkaFuture<Collection<Node>> nodes() {
/**
* Returns a future which yields the current controller node.
* <p>
* When using {@link AdminClientConfig#BOOTSTRAP_SERVERS_CONFIG}, the controller refer to a random broker.
* When using {@link AdminClientConfig#BOOTSTRAP_SERVERS_CONFIG}, the controller refers to a random broker.
* When using {@link AdminClientConfig#BOOTSTRAP_CONTROLLERS_CONFIG}, it refers to the current voter leader.
*/
public KafkaFuture<Node> controller() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public AbstractConfig(ConfigDef definition, Map<?, ?> originals, boolean doLog)
}

/**
* Called directly after user configs got parsed (and thus default values is not set).
* Called directly after user configs got parsed (and thus default values are not set).
* This allows to check user's config.
*
* @param parsedValues unmodifiable map of current configuration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ public Map<String, Object> parse(Map<?, ?> props) {
List<String> undefinedConfigKeys = undefinedDependentConfigs();
if (!undefinedConfigKeys.isEmpty()) {
String joined = undefinedConfigKeys.stream().map(String::toString).collect(Collectors.joining(","));
throw new ConfigException("Some configurations in are referred in the dependents, but not defined: " + joined);
throw new ConfigException("Some configurations are referred in the dependents but not defined: " + joined);
}
// parse all known keys
Map<String, Object> values = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

/**
* This allows plugins to register metrics and sensors.
* Any metrics registered by the plugin are automatically removed when the plugin closed.
* Any metrics registered by the plugin are automatically removed when the plugin is closed.
*/
public interface PluginMetrics {

Expand Down