Minor: Preserve user-provided acks config without mutation#21400
Open
anupamalok wants to merge 1 commit intoapache:trunkfrom
Open
Minor: Preserve user-provided acks config without mutation#21400anupamalok wants to merge 1 commit intoapache:trunkfrom
anupamalok wants to merge 1 commit intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
Author
|
All tests passed locally and in CI. |
anupamalok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
KafkaProducer currently normalize the
acksconfiguration by rewriting the user-provided value"all"to"-1"in the configs map during initialisation. This mutates the user's original configuration even though both values are semantically equivalent.Fix
Preserve the user-provided
acksvalue in configs and only normalize it internally for protocol usage.Tests
Added a regression test to ensure KafkaProducer does not mutate the user-provided
acksconfiguration.Note: I do not currently have access to create Kafka JIRA issues.