Add post-collection facets support to the new faceting API #15518
Conversation
|
+1, thanks @epotyom -- this adds the capabilities of the first faceting impl (two-phased) to the new sandbox faceting engine? I'm curious about:
What's an example use-case? |
You are correct.
In Amazon product search, we want to add support for rank-dependent associative facets, e.g. sorting facets by max doc relevance, where the relevance expression depends on the ranks of the top-N matching documents. Other potential use cases that come to mind are dynamic ranges (which require numeric values for all matches before they can be computed), and percentile aggregates for facets. Note that this change isn’t the only thing we need to integrate these features with the new faceting API, but it enables them in the future. |
| drillSidewaysManagers.put("dim1", new DocCountCollectorManager()); | ||
|
|
||
| // Use multi-threaded executor | ||
| java.util.concurrent.ExecutorService executor = |
There was a problem hiding this comment.
We don't normally import classes this way. Is there a reason for it?
There was a problem hiding this comment.
No particular reason, fixed in the commit below, thanks!
stefanvodita
left a comment
stefanvodita
left a comment
There was a problem hiding this comment.
Thank you for addressing the comment and for adding a changelog entry! I'm happy with the PR. For transparency: I've also reviewed this code when we committed it to Amazon's sources, so I'll wait a few days before pushing in case others want to review.
3 participants
Add post-collection facets support to the new faceting API.
Normally, users can collect facets directly during search without needing FacetsCollector to store doc IDs. However, this class implements the second step of two-step collection: iterating over doc IDs already collected in FacetsCollector to compute facet results. This approach is useful when all matches must be known before computing facets, or when reusing the same matching documents to run faceting multiple times.
Source: Facets during collection development plan