examples/rmtchar: fix source file ordering for RMTCHAR#3424
Open
fdcavalcanti wants to merge 1 commit intoapache:masterfrom
Open
examples/rmtchar: fix source file ordering for RMTCHAR#3424fdcavalcanti wants to merge 1 commit intoapache:masterfrom
fdcavalcanti wants to merge 1 commit intoapache:masterfrom
Conversation
rmtchar_main.c is coming after rmtchar_common.c, which causes an undefined reference error. This change fixes the problem. Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
cederom
approved these changes
Mar 13, 2026
Contributor
cederom
left a comment
There was a problem hiding this comment.
Thank you @fdcavalcanti :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmtchar_main.c is coming after rmtchar_common.c, which causes an undefined reference error. This change fixes the problem.
Impact
Impact on user: Yes, allows building rmt example using CMake.
Impact on build: Yes, fixes build error.
Impact on hardware: No.
Impact on documentation: No.
Impact on security: No.
Impact on compatibility: No.
Testing
Build the
rmtdefconfig foresp32h2-devkit(CMake support for ESP32 devices is a work in progress).Building
cmake -B build -DBOARD_CONFIG=esp32h2-devkit:rmt -GNinjacmake --build buildResults
Before the change:
After the change: