Skip to content

sched/wqueue: Align hp_work_stack/lp_work_stack #18388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pangzhen1xiaomi wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

sched/wqueue: Align hp_work_stack/lp_work_stack #18388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions sched/wqueue/kwork_thread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,14 +559,21 @@ int work_start_highpri(void)
sinfo("Starting high-priority kernel worker thread(s)\n");

#ifdef SCHED_HPWORKSTACKSECTION
static uint8_t hp_work_stack[CONFIG_SCHED_HPNTHREADS]
[CONFIG_SCHED_HPWORKSTACKSIZE]
/* Ensure each stack is properly aligned by rounding up the stack size.
* This is critical when CONFIG_SCHED_HPNTHREADS > 1 to ensure all
* thread stacks start at properly aligned addresses.
*/

#define HP_WORK_STACK_SIZE STACK_ALIGN_UP(CONFIG_SCHED_HPWORKSTACKSIZE)

static aligned_data(STACK_ALIGNMENT) uint8_t
hp_work_stack[CONFIG_SCHED_HPNTHREADS][HP_WORK_STACK_SIZE]
locate_data(CONFIG_SCHED_HPWORKSTACKSECTION);

return work_thread_create(HPWORKNAME,
CONFIG_SCHED_HPWORKPRIORITY,
hp_work_stack,
CONFIG_SCHED_HPWORKSTACKSIZE,
HP_WORK_STACK_SIZE,
(FAR struct kwork_wqueue_s *)&g_hpwork);
#else
return work_thread_create(HPWORKNAME, CONFIG_SCHED_HPWORKPRIORITY, NULL,
Expand Down Expand Up @@ -599,14 +606,21 @@ int work_start_lowpri(void)
sinfo("Starting low-priority kernel worker thread(s)\n");

#ifdef SCHED_LPWORKSTACKSECTION
static uint8_t lp_work_stack[CONFIG_SCHED_LPNTHREADS]
[CONFIG_SCHED_LPWORKSTACKSIZE]
/* Ensure each stack is properly aligned by rounding up the stack size.
* This is critical when CONFIG_SCHED_LPNTHREADS > 1 to ensure all
* thread stacks start at properly aligned addresses.
*/

#define LP_WORK_STACK_SIZE STACK_ALIGN_UP(CONFIG_SCHED_LPWORKSTACKSIZE)
Copy link
Contributor

@anchao anchao Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move define to Pre-processor Definitions section


static aligned_data(STACK_ALIGNMENT) uint8_t
lp_work_stack[CONFIG_SCHED_LPNTHREADS][LP_WORK_STACK_SIZE]
locate_data(CONFIG_SCHED_LPWORKSTACKSECTION);

return work_thread_create(LPWORKNAME,
CONFIG_SCHED_LPWORKPRIORITY,
lp_work_stack,
CONFIG_SCHED_LPWORKSTACKSIZE,
LP_WORK_STACK_SIZE,
(FAR struct kwork_wqueue_s *)&g_lpwork);
#else
return work_thread_create(LPWORKNAME,
Expand Down
Loading