feat: add SanityCheckLayer to detect unexpected list responses and ex… #6747
+4,426
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose SanityCheckLayer in mod.rs (apache#6646)
dosubot
bot
added
size:M
bytelazy
force-pushed
the
sanity-check-layer-6646
branch
from
39e69a6 to
8e959c2
Compare
dosubot
bot
added
size:L
Xuanwo
reviewed
Nov 3, 2025
| match self.inner.next().await? { | ||
| Some(entry) => { | ||
| let p = entry.path(); | ||
| if !p.starts_with(&self.prefix) { |
Member
There was a problem hiding this comment.
Hi, our original issue is about checking for duplicate keys.
Author
There was a problem hiding this comment.
Sorry, I might have misunderstood the issue. By “duplicate keys,” do you mean entries returned by the List operation that share the same path? For example, entry1.path() == entry2.path()?
Author
There was a problem hiding this comment.
Yes!
Hi @Xuanwo I’ve pushed the latest updates to address the feedback.
When you have a moment, could you please take another look?
Thanks a lot!
…6646 # Conflicts: # core/core/src/layers/sanity_check.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pose SanityCheckLayer in mod.rs (#6646)
Which issue does this PR close?
Closes #.6646
Rationale for this change
What changes are included in this PR?
add SanityCheckLayer to detect unexpected list responses and expose SanityCheckLayer in mod.rs
Are there any user-facing changes?
No changes to existing APIs but this add a new layer to choose