HDDS-14843. Support cluster-wide blacklist on OM#10037
Open
ivandika3 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14843. Support cluster-wide blacklist on OM#10037ivandika3 wants to merge 1 commit intoapache:masterfrom
ivandika3 wants to merge 1 commit intoapache:masterfrom
Conversation
adoroszlai
approved these changes
Apr 5, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ivandika3 for sharing the patch.
I would like to refactor OzoneAdmins and OzoneBlacklist, as there already is quite some duplication around this area, and this new class adds more. While it would have been easier before this change, now I think we should do it as a follow-up:
- refactoring first would require this to be reworked
- better to have the additional test coverage before refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have supported an internal user / group blacklist mechanisms to block some anomalous users from destabilizing the cluster for a while. The idea is similar to Ozone admin, but instead of allowing all access, blacklist denies all operations. The configuration is made reconfigurable to allow quick reaction after detection.
We should prefer to set readonly blacklist first before setting blacklist since (re)configuration is local to each OM (and not applied using Ratis), which might cause state divergence. Although some OM request already push the permission check to preExecute (not validateAndUpdateCache), there are still some requests (mostly multi-keys OM requests) still check in validateAndUpdateCache
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14843
How was this patch tested?
UT.
Clean CI: https://github.com/ivandika3/ozone/actions/runs/23936319511