-
Couldn't load subscription status.
- Fork 1.5k
GH-3289: Introduce Parquet E2E test harness to support CLI testing #3296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GH-3289: Introduce Parquet E2E test harness to support CLI testing #3296
Conversation
|
cc @gszadovszky as followup thanks! |
5d453a4 to
497858c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ArnavBalyan for picking this up. It is a great improvement to improve the test coverage of the cli!
parquet-cli/src/test/java/org/apache/parquet/cli/ShowSizeStatisticsCliTest.java
Show resolved
Hide resolved
parquet-cli/src/test/java/org/apache/parquet/cli/commands/FileTest.java
Outdated
Show resolved
Hide resolved
|
cc @gszadovszky this is ready thanks! |
|
@ArnavBalyan, could you check the failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ArnavBalyan.
|
Oh, the tests are still failing... |
|
Strangely I am not seeing it locally let me fix it |
3f7caa8 to
57011ae
Compare
linecount,partial matchetc.