Skip to content

Conversation

@ArnavBalyan
Copy link
Member

@ArnavBalyan ArnavBalyan commented Aug 30, 2025

  • Currently parquet does not have a good mechanism to have e2e testing for CLI
  • Developers have to manually call methods on the concrete class instead of the actual CLI route, this makes testing hard and prone to errors. Further the method return is tested instead of the actual console output.

  • This change introduces a test harness which is a wrapper over main CLI class and provides utilities to implement CLI tests easily.
  • Users can simply test with single line of code such as: cli("command").ok().matchOutputFromFile("txt"). The harness provides some other utilities like linecount, partial match etc.
  • The CLI output can be added to a txt to ensure readability and test the actual console output

@ArnavBalyan
Copy link
Member Author

ArnavBalyan commented Aug 30, 2025

cc @gszadovszky as followup thanks!

@ArnavBalyan ArnavBalyan changed the title GH-3289: Introduce e2e test harness to support cli tests GH-3289: Introduce e2e test harness to support cli Aug 30, 2025
@ArnavBalyan ArnavBalyan changed the title GH-3289: Introduce e2e test harness to support cli GH-3289: Introduce Parquet e2e test harness to support cli Aug 30, 2025
@ArnavBalyan ArnavBalyan force-pushed the arnavb/support-e2e-cli-tests branch from 5d453a4 to 497858c Compare August 30, 2025 14:06
@ArnavBalyan ArnavBalyan changed the title GH-3289: Introduce Parquet e2e test harness to support cli GH-3289: Introduce Parquet E2E test harness to support CLI testing Aug 30, 2025
Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ArnavBalyan for picking this up. It is a great improvement to improve the test coverage of the cli!

@ArnavBalyan
Copy link
Member Author

cc @gszadovszky this is ready thanks!

@gszadovszky
Copy link
Contributor

@ArnavBalyan, could you check the failures?

Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ArnavBalyan.

@gszadovszky
Copy link
Contributor

Oh, the tests are still failing...

@ArnavBalyan
Copy link
Member Author

Strangely I am not seeing it locally let me fix it

@ArnavBalyan ArnavBalyan force-pushed the arnavb/support-e2e-cli-tests branch from 3f7caa8 to 57011ae Compare September 5, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants