GH-3451. Add a JMH benchmark for variants#3452
Draft
steveloughran wants to merge 1 commit intoapache:masterfrom
Draft
GH-3451. Add a JMH benchmark for variants#3452steveloughran wants to merge 1 commit intoapache:masterfrom
steveloughran wants to merge 1 commit intoapache:masterfrom
Conversation
Initial impl.
Contributor
Author
|
Still thinking of what else can be done here...suggestions welcome. Probably a real write to the localfs and read back in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There's no benchmark for variant IO and so there's no knowledge of any problems which exist now, or any way to detect regressions.
What changes are included in this PR?
VariantBenchmarkAre these changes tested?
Manually, initial PR doesn't fork the JVM for each option.
there's 100 iterations per benchmark because some of the unshredded/small object operations are so fast that clock granuarity becomes an issue.
Are there any user-facing changes?
No
Closes #3451