Skip to content

chore: Deprecate Source#future in javadsl #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
He-Pin merged 2 commits into from
Dec 17, 2025
+3 −1
Merged

chore: Deprecate Source#future in javadsl #2555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a1afb
chore: Deprecate Source#future in javadsl
He-Pin Dec 6, 2025
15ac4ed
Update stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.s…
He-Pin Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stream-tests/src/test/java/org/apache/pekko/stream/javadsl/LazyAndFutureSourcesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public LazyAndFutureSourcesTest() {
// note these are minimal happy path tests to cover API, more thorough tests are on the Scala side

@Test
@SuppressWarnings("deprecation")
public void future() throws Exception {
CompletionStage<List<String>> result =
Source.future(Future.successful("one")).runWith(Sink.seq(), system);
Expand Down
3 changes: 2 additions & 1 deletion stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ object Source {
*
* Here for Java interoperability, the normal use from Java should be [[Source.completionStage]]
*/
@deprecated("Use 'Source.completionStage' or 'scaladsl.Source.future' instead", "1.5.0")
def future[T](futureElement: Future[T]): Source[T, NotUsed] =
scaladsl.Source.future(futureElement).asJava

Expand All @@ -406,7 +407,7 @@ object Source {
* If the `CompletionStage` is completed with a failure the stream is failed.
*/
def completionStage[T](completionStage: CompletionStage[T]): Source[T, NotUsed] =
future(completionStage.asScala)
new Source(scaladsl.Source.future(completionStage.asScala))

/**
* Turn a `CompletionStage[Source]` into a source that will emit the values of the source when the future completes successfully.
Expand Down
Loading