PHOENIX-7721 Implementation for Admin Tool for Consistent Failover #2310
+2,479
−629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritegarg
force-pushed
the
PHOENIX-7566-1030
branch
from
0e924c7 to
ebb81be
Compare
kadirozde
reviewed
Nov 11, 2025
Contributor
kadirozde
left a comment
kadirozde
left a comment
There was a problem hiding this comment.
The tool looks good overall. We need more description for its commands. Please see my comments on this.
| /** | ||
| * The command line tool to manage high availability (HA) groups and their cluster roles. | ||
| * Command-line tool to manage HAGroupStoreRecord configurations. | ||
| * Updates both ZooKeeper and System.HA_GROUP table atomically. |
Contributor
There was a problem hiding this comment.
We update ZK atomically but not the system table. The description and code comments should clarify this. It is also possible that the system table update may fail.
| .addOption(LIST_OPT) | ||
| .addOption(REPAIR_OPT); | ||
| // Commands | ||
| private static final String CMD_UPDATE = "update"; |
Contributor
There was a problem hiding this comment.
Can we write enough description for each command to explain what exactly the command does and which parameters it requires? What happens when one ZK URL vs two ZK URLs are given? How are failures handled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin Tool in Consistent HA for
Integration Tests Added