Skip to content

[fix][broker]V1 topic creation should fail if namespace does not exist #24882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
poorbarcode wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[fix][broker]V1 topic creation should fail if namespace does not exist #24882

poorbarcode wants to merge 12 commits into from

Conversation

@poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Oct 22, 2025

Motivation

V1 topic creation is allowed even if the namespace does not exist. After a topic creation, users will get the following concerns

  • users will get a namespace not found error when calling pulsar-admin topics list <v1 namespace>
  • users will get an empty list when calling pulsar-admin topics list <v2 namespace>

Modifications

  • fix the bug.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.2.0 milestone Oct 22, 2025
@poorbarcode poorbarcode self-assigned this Oct 22, 2025
@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug ready-to-test release/4.1.2 release/4.0.8 labels Oct 22, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 22, 2025
@poorbarcode poorbarcode force-pushed the fix/v1_topic_creation branch from 0c5a911 to e046576 Compare October 27, 2025 02:10
@lhotari
Copy link
Member

lhotari commented Oct 31, 2025

This test failure might be related to the changes:

  Error:  Failures: 
  Error:  org.apache.pulsar.broker.admin.AdminApiSchemaTest.getTopicIntervalStateIncludeSchemaStoreLedger
  [INFO]   Run 1: PASS
  Error:    Run 2: AdminApiSchemaTest.getTopicIntervalStateIncludeSchemaStoreLedger:292 » NotFound V1 namespace [schematest/test] does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@dao-jun dao-jun dao-jun approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@coderzc coderzc Awaiting requested review from coderzc

Assignees

@poorbarcode poorbarcode

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.9 release/4.1.3 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@poorbarcode @lhotari @Technoboy- @dao-jun