-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][misc] Upgrade to Jetty 12.1.x #25100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhotari
wants to merge
4
commits into
apache:master
Choose a base branch
from
lhotari:lh-jetty-12-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8,003
−1,563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR is ready for review, I just marked it draft so that we don't merge it before we are ready to do so. |
de6e02b to
0bcfbcd
Compare
709d41b to
2cd5c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22939
Motivation
Jetty 9.x currently used by Pulsar is not maintained anymore. The end of community support was in 6/2022 and end of life in 1/2025: jetty/jetty.project#7958
Jetty 9.4.58.v20250814 contains CVE-2024-6763 and there aren't plans to address it in Jetty 9 since it's end-of-life.
Modifications
jetty-upgradedirectory.ServletHolder getServletHolder()method withObject getServletInstance()method in theAdditionalServletinterface. This currently supportsjavax.servlet.Servletinstances, but later on support forjakarta.servlet.Servletcould be added.Additional information
There's some remaining use of Jetty 9 in the project.
Please notice that this upgrade contains a breaking change in the org.apache.pulsar.broker.web.plugin.servlet.AdditionalServlet interface due to the existing interface coupling directly to Jetty 9 implementation details with the use of
org.eclipse.jetty.servlet.ServletHolderclass in theAdditionalServletinterface. This coupling has been removed in this PR.Documentation
docdoc-requireddoc-not-neededdoc-complete