[fix][test] Fix flaky BrokerRegistryIntegrationTest port binding race#25463
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky BrokerRegistryIntegrationTest port binding race#25463merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
Move port allocation and LocalBookkeeperEnsemble creation from field initialization to @BeforeClass to avoid port reuse. Use port 0 to let the OS automatically allocate free ports. Add null guard for bk in cleanup to handle setup failures gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BrokerRegistryIntegrationTest.setupis flaky due to a port binding race condition. Ports are allocated at field initialization time viaPortManager.nextFreePort(), but by the time@BeforeClassruns, those ports may have been reused by another test class.Stack trace
Modifications
LocalBookkeeperEnsemblecreation from field initialization to@BeforeClass0for automatic OS port allocation instead ofPortManager.nextFreePort()bkin cleanup to handle setup failures gracefullyDocumentation
doc-not-needed