[fix][test] Fix flaky FunctionRuntimeManagerTest.testExternallyManagedRuntimeUpdate#25465
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky FunctionRuntimeManagerTest.testExternallyManagedRuntimeUpdate#25465merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…dRuntimeUpdate Add clearInvocations between the two verification blocks in the test to prevent accumulated Mockito spy invocations from interfering with the second verify block's times(0) assertions.
github-actions
bot
added
doc-label-missing
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FunctionRuntimeManagerTest.testExternallyManagedRuntimeUpdateis flaky because accumulated Mockito spy invocations from the first test section leak into the second verification block.Stack trace
Modifications
Add
Mockito.clearInvocations(functionActioner)between the two verification blocks ("transfer from me to other worker" and "transfer from other worker to me") so thatverify(times(0))assertions in the second block are not affected by invocations from the first block.Documentation
doc-not-needed