[fix][test] Fix flaky MembershipManagerTest.testCheckFailuresSomeFailures#25466
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky MembershipManagerTest.testCheckFailuresSomeFailures#25466merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…ures Add clearInvocations on Mockito spies between setup and first checkFailures call, and between the two checkFailures calls, to prevent accumulated invocations from interfering with times() assertions.
github-actions
bot
added
doc-label-missing
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MembershipManagerTest.testCheckFailuresSomeFailuresis flaky because accumulated Mockito spy invocations from setup and the firstcheckFailurescall leak into subsequent verification blocks.Stack trace
Modifications
Add
Mockito.clearInvocations(functionRuntimeManager, schedulerManager)in two places:setAssignmentcalls and before the firstcheckFailurescallcheckFailurescallThis ensures each
verify(times(...))assertion only counts invocations from its own test section.Documentation
doc-not-needed