[fix][test] Fix flaky ConsumerBatchReceiveTest.testBatchReceiveAndRedeliveryNonPartitionedTopic#25468
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky ConsumerBatchReceiveTest.testBatchReceiveAndRedeliveryNonPartitionedTopic#25468merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…eliveryNonPartitionedTopic Move consumer.acknowledge(messages) inside the null check to avoid NPE when batchReceive returns null. Change strict equality assertion to >= since ack timeout redelivery can cause extra messages to be received.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ConsumerBatchReceiveTest.testBatchReceiveAndRedeliveryNonPartitionedTopicis flaky due to two issues:consumer.acknowledge(messages)is called outside the null check, causing NPE whenbatchReceive()returns nullStack trace
Modifications
consumer.acknowledge(messages)inside theif (messages != null)blockassertEquals(expected * 2, messageReceived)toassertTrue(messageReceived >= expected * 2)since redelivery can produce extra messagesDocumentation
doc-not-needed