[fix][test] Fix flaky PulsarFunctionsJavaThreadTest by adding retry to getFunctionStats#25472
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky PulsarFunctionsJavaThreadTest by adding retry to getFunctionStats#25472merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…o getFunctionStats The getFunctionStats method had no retry logic, unlike getFunctionStatus which uses Awaitility. When the stats endpoint isn't ready yet or metrics haven't been collected, the command fails with a non-zero exit code. Wrap the stats retrieval in Awaitility.await() with a 15-second timeout, matching the pattern used by getFunctionStatus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarFunctionsJavaThreadTest.testJavaExclamationCustomBatchingFunctionis flaky becausegetFunctionStats()has no retry logic — unlikegetFunctionStatus()which wraps its logic inAwaitility.await(). When function stats aren't available yet (metrics not collected, stats endpoint not ready), thepulsar-admin functions statscommand fails with a non-zero exit code.Stack trace
Modifications
Wrap
getFunctionStats()inAwaitility.await()withpollInterval(1s)andatMost(15s), matching the existing pattern used bygetFunctionStatus(). The actual assertions are moved to adoGetFunctionStats()method.Documentation
doc-not-needed