[fix][test] Fix flaky IsolatedBookieEnsemblePlacementPolicyTest.testBookieInfoChange#25473
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
Conversation
…ookieInfoChange Add Awaitility wait for the async cache load triggered by initialize() to complete before calling newEnsemble(). Without this, the cachedRackConfiguration can be null, causing no bookie isolation and the ensemble may include bookies from the wrong group.
dao-jun
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IsolatedBookieEnsemblePlacementPolicyTest.testBookieInfoChangeis flaky becauseinitialize()loads the bookie rack configuration asynchronously. WhennewEnsemble()runs before the async load completes,cachedRackConfigurationis null, no bookie isolation is applied, and the ensemble may include bookies from the wrong group.Stack trace
Modifications
Add an Awaitility wait after
initialize()to ensure the async cache load has completed before callingnewEnsemble().Documentation
doc-not-needed