Skip to content

Conversation

@qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9737

Brief Description

How Did You Test This Change?

fuyou001
fuyou001 previously approved these changes Sep 26, 2025
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caigy
caigy previously approved these changes Sep 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.29%. Comparing base (d750461) to head (bfd3d83).

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 30.76% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9740      +/-   ##
=============================================
- Coverage      48.35%   48.29%   -0.06%     
+ Complexity     12270    12255      -15     
=============================================
  Files           1314     1314              
  Lines          93875    93875              
  Branches       12040    12041       +1     
=============================================
- Hits           45395    45340      -55     
- Misses         42867    42911      +44     
- Partials        5613     5624      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qianye1001 qianye1001 marked this pull request as draft September 26, 2025 03:38
@qianye1001 qianye1001 dismissed stale reviews from caigy and fuyou001 via ab90545 September 28, 2025 07:35
@qianye1001 qianye1001 marked this pull request as ready for review September 28, 2025 07:37
Change-Id: Iae6c4757a928da0cde6d5c1115b4a745620d7d81
@qianye1001 qianye1001 force-pushed the fix-channelWrapperTables-mem-leak branch from 0c64224 to bfd3d83 Compare November 19, 2025 02:37
@lizhimins lizhimins merged commit 7acfe4d into apache:develop Nov 19, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Client memory leak on connection failure

5 participants