Add chart README caveat for 'addtionalLibs' #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The warning could use some word-smithing, and it probably makes sense to mention in the CRD field description too. Just wanted to get some version of the PR up here before I forgot to document the limitation... |
Contributor
Author
|
Alright, I've updated the CRD description to include the same caveat as the helm chart README docs. This is ready to merge 👍 |
Contributor
Author
|
(No changelog entry as this is just a minor doc tweak) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed recently that the setting wasn't working in a 'solrcloud', as the operator's main way to implement this feature is by creating
<sharedLib>entries in thesolr.xmlfile that it generates. When users provide their ownsolr.xml, there's no way for the operator to inject/obey the "additionalLibs" setting.