-
Notifications
You must be signed in to change notification settings - Fork 790
SOLR-17864: Use modern format for allow urls and allow paths #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is ready for review!!!!!!!!! |
dsmiley
reviewed
Oct 29, 2025
Contributor
dsmiley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the one thing
epugh
added a commit
that referenced
this pull request
Oct 31, 2025
* Migrate solr.allowPaths to solr.security.allow.paths * Migrate solr.allowUrls to solr.security.allow.urls * add properties to the ref guide
epugh
added a commit
that referenced
this pull request
Oct 31, 2025
* Migrate solr.allowPaths to solr.security.allow.paths * Migrate solr.allowUrls to solr.security.allow.urls * add properties to the ref guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:cloud
client:solrj
configs
documentation
Improvements or additions to documentation
jetty-server
module:opentelemetry
start-scripts
test-framework
tests
tool:build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17864
Continuing the march, we already did
solr.security.allow.urls.enabled, now lets do the variable that it sets.