[SPARK-54919][SQL] Remove AgnosticExpressionPathEncoder usage tech-debt #53697
+5
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-54919 === This comment was automatically generated by GitHub Actions |
Contributor
Author
|
@hvanhovell @HyukjinKwon @LuciferYang, removing SPARK-49960, apologies for the delay on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
4.0.0 provided interim backwards compatibility to custom encoders via AgnosticExpressionPathEncoder in SPARK-49960 pr #50023. As part of that PR AgnosticExpressionPathEncoder was deprecated from the get go with a commitment to remove it in 4.1, this PR covers that tech-debt removal.
Why are the changes needed?
AgnosticEncoder's support encoding on both connect client and classic driver side, #50023 provided a migration path to 4.x with the intention to have software migrate to direct AgnosticEncoder usage (with custom encoders using TransformingEncoder/Codecs).
This PR reduces tech-debt via removing this bridge / migration support code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
1 test was removed alongside the code.
Was this patch authored or co-authored using generative AI tooling?
No